fix: validate load target cda - #236
Merged
Merged
Conversation
krowvin
force-pushed
the
fix-185-validate-target-cda
branch
from
July 11, 2026 23:04
cf8a717 to
3aa4f87
Compare
krowvin
marked this pull request as ready for review
July 12, 2026 00:28
Collaborator
Author
|
Talked to others at CURG about this. Will take it back out if it causes latency/load time issues. |
msweier
pushed a commit
that referenced
this pull request
Aug 10, 2026
🤖 I have created a release *beep* *boop* --- ## [0.8.0](v0.7.4...v0.8.0) (2026-08-10) ### Features * Add CDA Environment Manager ([#209](#209)) ([a89bfb1](a89bfb1)) * add dev helper script to preview docs ([#253](#253)) ([749fedc](749fedc)) * Add modern DSS transfer utilities ([#242](#242)) ([89e01f4](89e01f4)) * allow for line return tsid parsing ([#230](#230)) ([39f7f6b](39f7f6b)) * display CDA server stack traces in debug mode ([#247](#247)) ([c3bfcf9](c3bfcf9)) ### Bug Fixes * align formatting checks ([#229](#229)) ([a6286b3](a6286b3)) * cover explicit blob media type ([#232](#232)) ([1a3b26d](1a3b26d)) * doc check, add link exception ([#255](#255)) ([0101968](0101968)) * explain empty location loads ([#233](#233)) ([a5b596c](a5b596c)) * harden clob download error handling ([#235](#235)) ([621f913](621f913)) * Improve version issue error message in deps.py ([#245](#245)) ([f77b75f](f77b75f)) * refresh ownership metadata ([#251](#251)) ([3b31479](3b31479)) * show update environment before confirmation ([#246](#246)) ([500435c](500435c)), closes [#222](#222) * validate blob list limits ([#231](#231)) ([0917ce9](0917ce9)) * validate load target cda ([#236](#236)) ([ff3e06a](ff3e06a)) * wait for auth callback server readiness ([#249](#249)) ([ca39d5b](ca39d5b)) ### Documentation * guide agents to shared color helpers ([#248](#248)) ([ef03276](ef03276)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--skip-target-cda-checkandCWMS_CLI_SKIP_TARGET_CDA_CHECKfor cases where the preflight should be bypassedWhy
Load dry-runs and copy operations should fail early when
--target-cdapoints somewhere that is not a CDA instance. This prevents users from validating or starting a load command against the wrong service, while still giving operators a bypass for unusual local or network conditions.Validation
poetry run pytest tests/load/test_cda_target_validation.py tests/commands/test_load_location_ids.py tests/commands/test_load_location_ids_bygroup.py tests/load/test_timeseries_data.py -qpoetry run pytest -qpoetry check(warnings only for existing Poetry metadata deprecations)